SuccessChanges

Summary

  1. spot iterators (details)
  2. spotbugs fixes in beantable (details)
  3. SH table null check safer (details)
  4. spotbugs oblock unchecked casts, iterator, nonnull (details)
  5. spotbugs null checks, safe casting, access, null selection combos, null (details)
  6. provide nonnull signalsystem in mast add tests as per contract, refactor (details)
  7. spotbugs LRoute empty array, not null (private method) (details)
  8. suppress unused warning as indirectly used, fixes Travis static (details)
  9. small update to task comments (details)
  10. remove spotbugs flagged redundant null check (details)
The file was modifiedjava/src/jmri/jmrit/beantable/usermessagepreferences/UserMessagePreferencesPane.java (diff)
Commit 08f899f35f68035ced9b2a599a587981dc757512 by dcc2
spotbugs fixes in beantable
The file was modifiedjava/src/jmri/jmrit/beantable/SignalGroupSubTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/LRouteTableAction.java (diff)
The file was modifiedjava/src/jmri/TurnoutOperation.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TurnoutTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SectionTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/MemoryTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TransitTableAction.java (diff)
Commit 924f13e9a7a7f80c5b7e717f42bc6febb8a34417 by dcc2
SH table null check safer
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
Commit 587af3354e4e616dc9fad8bf10451a46b3dbb84f by dcc2
spotbugs oblock unchecked casts, iterator, nonnull
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/TableFrames.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/DnDJTable.java (diff)
Commit 66fbf51681319cb4c340ef075baf9e43deeafb35 by dcc2
spotbugs null checks, safe casting, access, null selection combos, null
params, matrixadd unused imports
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/VirtualSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/AddSignalMastPanel.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/SignalHeadSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/beanedit/TurnoutEditAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/TurnoutSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TurnoutTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/DnDJTable.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPane.java (diff)
Commit a9cfd99756b61e113623543a53c4a537a526cb11 by dcc2
provide nonnull signalsystem in mast add tests as per contract, refactor
inverted tests, correct dcc mast test appearance mast
The file was modifiedjava/test/jmri/implementation/MatrixSignalMastTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/DccSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/SignalHeadSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/VirtualSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/TurnoutSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/AbstractSignalMastAddPaneTestBase.java (diff)
The file was modifiedjava/test/jmri/jmrix/openlcb/swing/OlcbSignalMastAddPaneTest.java (diff)
The file was modifiedjava/src/jmri/jmrix/openlcb/swing/OlcbSignalMastAddPane.java (diff)
Commit 7db469c87ba3695f4ea096ae6955a08961d5ff51 by dcc2
spotbugs LRoute empty array, not null (private method)
The file was modifiedjava/src/jmri/jmrit/beantable/LRouteTableAction.java (diff)
Commit 126eceb23aad465e6859adbee82be57701095cb5 by dcc2
suppress unused warning as indirectly used, fixes Travis static
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPaneTest.java (diff)
Commit ee14131b7d1d2915162ae48d99690707e0100330 by Bob Jacobsen
small update to task comments
The file was modifiedbuild.xml (diff)
Commit ad90d8f4a18efe6bbbdd85efb5cf971003bd427d by dcc2
remove spotbugs flagged redundant null check
The file was modifiedjava/src/jmri/TurnoutOperationManager.java (diff)