UnstableChanges

Summary

  1. spot iterators (details)
  2. spotbugs fixes in beantable (details)
  3. SH table null check safer (details)
  4. spotbugs oblock unchecked casts, iterator, nonnull (details)
  5. spotbugs null checks, safe casting, access, null selection combos, null (details)
  6. provide nonnull signalsystem in mast add tests as per contract, refactor (details)
  7. spotbugs LRoute empty array, not null (private method) (details)
  8. suppress unused warning as indirectly used, fixes Travis static (details)
  9. spotbugs happy: return empty array, not null (details)
  10. small update to task comments (details)
  11. handle empty baud arrays returned, fix 3 minor AbstractMonPane spots (details)
  12. remove spotbugs flagged redundant null check (details)
  13. adjust tests, prevent IOB for empty baud combos (details)
  14. fix: Allow VS Code Java Tester to function (details)
The file was modifiedjava/src/jmri/jmrit/beantable/usermessagepreferences/UserMessagePreferencesPane.java (diff)
Commit 08f899f35f68035ced9b2a599a587981dc757512 by dcc2
spotbugs fixes in beantable
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TurnoutTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TransitTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SignalGroupSubTableAction.java (diff)
The file was modifiedjava/src/jmri/TurnoutOperation.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/LRouteTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/MemoryTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SectionTableAction.java (diff)
Commit 924f13e9a7a7f80c5b7e717f42bc6febb8a34417 by dcc2
SH table null check safer
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
Commit 587af3354e4e616dc9fad8bf10451a46b3dbb84f by dcc2
spotbugs oblock unchecked casts, iterator, nonnull
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/DnDJTable.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/TableFrames.java (diff)
Commit 66fbf51681319cb4c340ef075baf9e43deeafb35 by dcc2
spotbugs null checks, safe casting, access, null selection combos, null
params, matrixadd unused imports
The file was modifiedjava/src/jmri/jmrit/beantable/oblock/DnDJTable.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/SignalHeadTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/AddSignalMastPanel.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/SignalHeadSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/VirtualSignalMastAddPane.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/beanedit/TurnoutEditAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/TurnoutTableAction.java (diff)
The file was modifiedjava/src/jmri/jmrit/beantable/signalmast/TurnoutSignalMastAddPane.java (diff)
Commit a9cfd99756b61e113623543a53c4a537a526cb11 by dcc2
provide nonnull signalsystem in mast add tests as per contract, refactor
inverted tests, correct dcc mast test appearance mast
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/SignalHeadSignalMastAddPaneTest.java (diff)
The file was modifiedjava/src/jmri/jmrix/openlcb/swing/OlcbSignalMastAddPane.java (diff)
The file was modifiedjava/test/jmri/jmrix/openlcb/swing/OlcbSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/implementation/MatrixSignalMastTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/TurnoutSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/AbstractSignalMastAddPaneTestBase.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/VirtualSignalMastAddPaneTest.java (diff)
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/DccSignalMastAddPaneTest.java (diff)
Commit 7db469c87ba3695f4ea096ae6955a08961d5ff51 by dcc2
spotbugs LRoute empty array, not null (private method)
The file was modifiedjava/src/jmri/jmrit/beantable/LRouteTableAction.java (diff)
Commit 126eceb23aad465e6859adbee82be57701095cb5 by dcc2
suppress unused warning as indirectly used, fixes Travis static
The file was modifiedjava/test/jmri/jmrit/beantable/signalmast/MatrixSignalMastAddPaneTest.java (diff)
Commit d43aa11f62387fe45d710b88edfee369e8d4c73e by dcc2
spotbugs happy: return empty array, not null
The file was modifiedjava/src/jmri/jmrix/oaktree/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/tams/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/secsi/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/sprog/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/direct/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/tmcc/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/AbstractSerialPortController.java (diff)
The file was modifiedjava/src/jmri/jmrix/mrc/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/lenz/XNetSimulatorPortController.java (diff)
The file was modifiedjava/src/jmri/jmrix/nce/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/powerline/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/grapevine/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/loconet/bluetooth/LocoNetBluetoothAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/dccpp/simulator/DCCppSimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/easydcc/simulator/SimulatorAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/internal/InternalAdapter.java (diff)
The file was modifiedjava/src/jmri/jmrix/loconet/hexfile/LnHexFilePort.java (diff)
The file was modifiedjava/src/jmri/jmrix/maple/simulator/SimulatorAdapter.java (diff)
Commit ee14131b7d1d2915162ae48d99690707e0100330 by Bob Jacobsen
small update to task comments
The file was modifiedbuild.xml (diff)
Commit 351fbf89759384140e6aa054b88eec9c04769af5 by dcc2
handle empty baud arrays returned, fix 3 minor AbstractMonPane spots
The file was modifiedjava/src/jmri/jmrix/AbstractSerialPortController.java (diff)
The file was modifiedjava/src/jmri/jmrix/AbstractMonPane.java (diff)
Commit ad90d8f4a18efe6bbbdd85efb5cf971003bd427d by dcc2
remove spotbugs flagged redundant null check
The file was modifiedjava/src/jmri/TurnoutOperationManager.java (diff)
Commit 51d878c110b1bd86fb70c1cb8effe3d2a890b69d by dcc2
adjust tests, prevent IOB for empty baud combos
The file was modifiedjava/test/jmri/jmrix/easydcc/simulator/EasyDccSimulatorTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/powerline/cm11/SpecificTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/grapevine/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/easydcc/EasyDccTrafficControllerTest.java (diff)
The file was modifiedjava/src/jmri/jmrix/loconet/bluetooth/ConnectionConfig.java (diff)
The file was modifiedjava/test/jmri/jmrix/powerline/insteon2412s/SpecificTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/oaktree/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/src/jmri/jmrix/AbstractConnectionConfig.java (diff)
The file was modifiedjava/test/jmri/jmrix/AbstractConnectionConfigTestBase.java (diff)
The file was modifiedjava/test/jmri/jmrix/lenz/XNetPortControllerScaffold.java (diff)
The file was modifiedjava/test/jmri/jmrix/lenz/xntcp/XnTcpPortControllerScaffold.java (diff)
The file was modifiedjava/test/jmri/jmrix/nce/NceTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/secsi/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/qsi/QsiTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/powerline/simulator/SpecificTrafficControllerTest.java (diff)
The file was modifiedjava/src/jmri/jmrix/AbstractSerialConnectionConfig.java (diff)
The file was modifiedjava/test/jmri/jmrix/dccpp/DCCppPortControllerScaffold.java (diff)
The file was modifiedjava/test/jmri/jmrix/acela/AcelaTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/maple/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/loconet/LnPortControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/cmri/serial/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/tmcc/SerialTrafficControllerTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/nce/simulator/SimulatorAdapterTest.java (diff)
The file was modifiedjava/test/jmri/jmrix/dcc4pc/Dcc4PcTrafficControllerTest.java (diff)
Commit 1c4324f31f2599324b9058da8cb834563e40cb30 by noreply
fix: Allow VS Code Java Tester to function
This fixes in-IDE unit testing in Visual Studio Code after #7105 broke
it.
The file was modified.vscode/settings.json (diff)